Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bellatrix OpenCV ActionImage Update #49

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

teo-nikolov
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@n1xan n1xan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I think it is okay, but we have to think whether this approach i applicable in mobile and desktop tests as well, which means we will have to move this to a separate module, or apply the component to the other modules as well,


public String toString() {
return "By.imageBase64: " + this.base64EncodedImage;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking of renaming the class to ByImage, which has overloads for base64 string, and also file path.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to create it as a separate class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants