Make the “raw data” button optional #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsxschneider
approved these changes
Jan 23, 2018
|
@larsxschneider: Good idea, the commits belong together. I’ll squash them! |
This introduces a new configuration option “showRawDataLink,” through which the “raw data” button can be explicitly hidden. This is used for hiding the “raw data” download button in the collaboration chart, where the raw data isn’t useful to view or edit in a spreadsheet application. Additionally, the documentation is extended to cover the new option.
The margins of chart titles were incorrect in the case that the corresponding action bar was hidden. This change applies the same style to all titles, regardless of whether an action bar is shown or not.
pluehne
force-pushed
the
patrick/optional-raw-button-link
branch
from
118c075
to
864ade5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new configuration option “showRawDataLink,” through which the “raw data” button can be explicitly hidden (requested in #87).
This is used for hiding the “raw data” download button in the collaboration chart, where the raw data isn’t useful to view or edit in a spreadsheet application.
Also, the margins of chart titles were incorrect in the case that the corresponding action bar was hidden. This change applies the same style to all titles, regardless of whether an action bar is shown or not.
See how the “raw data” button is missing in the screenshot below 😄: