Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: citation file #695

Merged
merged 4 commits into from
Dec 4, 2024
Merged

update: citation file #695

merged 4 commits into from
Dec 4, 2024

Conversation

musslick
Copy link
Collaborator

@musslick musslick commented Dec 4, 2024 •
edited
Loading

@musslick musslick added the documentation Improvements or additions to documentation. label Dec 4, 2024
@musslick musslick added this to the JOSS Revision milestone Dec 4, 2024
@musslick musslick self-assigned this Dec 4, 2024
@listar2000
Copy link
Collaborator

Hi @musslick thanks for doing this. Is it possible to change my given name to the more official "Sida"? Thanks.

@musslick
Copy link
Collaborator Author

musslick commented Dec 4, 2024

Hi @musslick thanks for doing this. Is it possible to change my given name to the more official "Sida"? Thanks.

@listar2000 Done! Thanks for checking.

@listar2000 listar2000 enabled auto-merge December 4, 2024 21:19
listar2000
listar2000 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@listar2000 listar2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@listar2000 listar2000 added this pull request to the merge queue Dec 4, 2024
@listar2000 listar2000 removed this pull request from the merge queue due to a manual request Dec 4, 2024
@musslick musslick added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit c623639 Dec 4, 2024
16 checks passed
@musslick musslick deleted the doc/citation-update branch December 4, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@listar2000 listar2000 listar2000 approved these changes

@imtezcan imtezcan Awaiting requested review from imtezcan

@younesStrittmatter younesStrittmatter Awaiting requested review from younesStrittmatter

@hollandjg hollandjg Awaiting requested review from hollandjg

@chadcwilliams chadcwilliams Awaiting requested review from chadcwilliams

Assignees

@musslick musslick

Labels
documentation Improvements or additions to documentation.
Projects
None yet
Milestone
JOSS Revision
Development

Successfully merging this pull request may close these issues.
2 participants
@musslick @listar2000