Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/closed loop example bandit task #661

Merged

Conversation

younesStrittmatter
Copy link
Collaborator

Description

add a closed-loop example with rnn-sindy theorist and model disagreement sampler

  • docs: Documentation only changes

@younesStrittmatter
Copy link
Collaborator Author

i copied the img folder so i could reuse the images easier. But they are now duplicates.

Copy link
Collaborator

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good so far. In this PR, I noticed that the images were moved one level up from examples/closed-loop-basic/img to examples/img. Was this intended? If so, we should also fix the corresponding links in the closed-loop-basic doc.

Copy link
Collaborator

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@musslick musslick merged commit 1f54c32 into doc/closed-loop-example-basic Oct 16, 2024
16 checks passed
@musslick musslick deleted the doc/closed-loop-example-bandit-task branch October 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants