-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated contributor guide #627
Changes from 7 commits
d451b90
5f89606
9d297ce
4572f4d
1b79a87
9e3c6b3
292aa14
bce0e10
2c76288
8f0b4ce
97318d6
3c65848
84af832
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,9 +27,9 @@ After setting up your repository and linking it to your GitHub account, you can | |
You may implement your code in the ``init.py`` located in the respective feature folder in ``src/autora``. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line looks to be formatted incorrectly – it should show
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the catch! I committed a fix implementing the suggested renaming from 'init.py' to 'init.py'
musslick marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Please refer to the following guides on implementing | ||
- [theorists](theorist.md) | ||
- [experimentalists](experimentalist.md) | ||
- [experiment runners](experiment-runner.md) | ||
* [theorists](theorist.md) | ||
musslick marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* [experimentalists](experimentalist.md) | ||
* [experiment runners](experiment-runner.md) | ||
|
||
If the feature you seek to implement does not fit in any of these categories, then | ||
you can create folders for new categories. If you are unsure how to proceed, you are always welcome | ||
|
@@ -98,13 +98,16 @@ Once you've published your module, you should take some time to celebrate and an | |
Once your package is working and published, you can **make a pull request** on [`autora`](https://github.com/autoresearch/autora) to have it vetted and added to the "parent" package. Note, if you are not a member of the AutoResearch organization on GitHub, you will need to create a fork of the repository for the parent package and submit your pull request via that fork. If you are a member, you can create a pull request from a branch created directly from the parent package repository. Steps for creating a new branch to add your module are specified below. | ||
|
||
!!! success | ||
|
||
In order for your package to be included in the parent package, it must meet the following criteria: | ||
- have basic documentation in ``docs/index.md`` | ||
- have a basic python notebook exposing how to use the module in ``docs/Basic Usage.ipynb`` | ||
- have basic tests in ``tests/`` | ||
- be published via PyPI or Conda | ||
- be compatible with the current version of the parent package | ||
- follow standard python coding guidelines including PEP8 | ||
|
||
* have basic documentation in ``docs/index.md`` | ||
* have a basic python notebook exposing how to use the module in ``docs/Basic Usage.ipynb`` | ||
* have basic tests in ``tests/`` | ||
* be published via PyPI or Conda | ||
* be compatible with the current version of the parent package | ||
* follow standard python coding guidelines including PEP8 | ||
* the repository in which your package is hosted must be public | ||
|
||
The following demonstrates how to add a package published under `autora-theorist-example` in PyPI in the GitHub | ||
repository `example-contributor/contributor-theorist`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feeling is that the dependency arrows point in the wrong direction here, but that might be a question for a different PR and a different day – I know that the way they are feels intuitive for many.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great catch! We could use the most recent figure from the paper draft. I will create an issue so we can address it in a new PR.