-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs nav fix after 400 #591
Conversation
Also: Should work on the core documentation of the tutorials. Not sure if they are still up-to-date. But I still think this is better than having nothing at all in the user-guide (at least a start) |
@@ -158,11 +159,19 @@ nav: | |||
- III - Functional Workflow: 'tutorials/basic/Tutorial-III-Functional-Workflow.ipynb' | |||
- IV - Customization: 'tutorials/basic/Tutorial-IV-Customization.ipynb' | |||
- Advanced: | |||
- Equation Discovery: 'tutorials/Equation Discovery.ipynb' | |||
- Equation Discovery: 'theorist/Equation Discovery.ipynb' | |||
- Experimentalists: 'tutorials/Experimentalist.ipynb' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't really an advanced Experimentalist tutorial, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was in the advanced tutorials before, but was a broken link. I just changed the path.
BTW: There is another tutorial file in the advanced folder called "Theorist.ipynb" that we don't use anywhere right now. I was not sure about that one either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also mark the theorist/Equation Discovery.ipynb
file as requiring python3.10, because it uses the case-match
statement which is first available then. (Or we should use the old if-elif-else
syntax instead.) That would be a different PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
mkdocs.yml
Outdated
@@ -36,6 +36,7 @@ plugins: | |||
- name: core | |||
import_url: "https://github.com/autoresearch/autora-core/?branch=main" | |||
imports: [ | |||
"docs/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might be able to get away with just having docs/
and src/
:
"docs/",
"src/",
... and all the others you can delete. They seem irrelevant. Also, I'm not sure what the "*" is doing, if anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed and tested it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
We should work on the documentation for core (the index file is currently merely a placeholder)