Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Notebook Tutorial for Equation Discovery #568

Merged
merged 9 commits into from
Sep 28, 2023

Conversation

TheLemonPig
Copy link
Collaborator

@TheLemonPig TheLemonPig commented Sep 12, 2023

Copy & Paste Tutorial Notebook from autora-theorist-bms branch to autora branch

Description

closes #523

Type of change

Delete as appropriate:

  • docs: Documentation only changes

TheLemonPig and others added 6 commits September 12, 2023 15:22
Copy & Paste Tutorial Notebook from ```autora-theorist-bms``` branch to ```autora``` branch
Direct Equation Discovery notebook to new BMS Tutorial
…tist.ipynb to Equation Discovery

Rename File of new BMS Tutorial
@TheLemonPig
Copy link
Collaborator Author

Linking to AutoRA Project #523

Copy link
Collaborator

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The synthetic experiment runners interface has slightly changed (added_noise in the run function, not in the initialisation)

@benwandrew
Copy link
Collaborator

added_noise

also need to update the function name from experiment_runner to run, which i think i handled successfully in latest commit.

Copy link
Collaborator

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good now!

@benwandrew
Copy link
Collaborator

oh, i guess there's actually an error with the last cell under 6. Plot the Results for the Polynomial Regressor (no attribute model_, which is not included in the __init__ for that class). can we just delete the cell trying to print poly_model.model_?

@TheLemonPig
Copy link
Collaborator Author

@younesStrittmatter I am not sure why but merging is blocked because of your request for changes but it isn't saying I can re-request your review. Is there anything you can do on your end?

@TheLemonPig
Copy link
Collaborator Author

@younesStrittmatter anything you see still needing to be changed for this PR?

@TheLemonPig TheLemonPig added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 52f7f76 Sep 28, 2023
@TheLemonPig TheLemonPig deleted the docs/bms-tutorial branch September 28, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate BMS tutorial from modeling workshop into autora as new "Theorist Tutorial"
3 participants