Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fixes funding logo position and size #528

Merged
merged 2 commits into from
Jul 19, 2023
Merged

doc: fixes funding logo position and size #528

merged 2 commits into from
Jul 19, 2023

Conversation

musslick
Copy link
Collaborator

Description

This PR fixes funding logo position and size for the README and the index.md of the documentation.

If the issue is on Github, simply link to it using the '#' symbol; otherwise, provide a notion page link):

  • resolves #(issue)

Type of change

  • docs: Documentation only changes

@musslick musslick self-assigned this Jul 19, 2023
@musslick musslick added documentation Improvements or additions to documentation. PI Priority labels Jul 19, 2023
Copy link
Collaborator

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hollandjg
Copy link
Member

I'm not sure this will work for the README and PyPI. You could try making a preview release based on this branch to see whether the images are shown correctly on PyPI.

The alternative is to include the full path to the image (the full https://...) rather than the relative path which is treated differently on GitHub vs on PyPI.

@musslick
Copy link
Collaborator Author

I'm not sure this will work for the README and PyPI. You could try making a preview release based on this branch to see whether the images are shown correctly on PyPI.

The alternative is to include the full path to the image (the full https://...) rather than the relative path which is treated differently on GitHub vs on PyPI.

Interestingly, the HTML specification <img ... width="100"> did not work in the documentation. However, I circumvented the issue by reducing the size of the images.

@musslick musslick added this pull request to the merge queue Jul 19, 2023
Merged via the queue into main with commit e68c613 Jul 19, 2023
@musslick musslick deleted the doc/logo-fix branch July 19, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants