503 fix broken links #504
Merged
503 fix broken links #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesStrittmatter
requested review from
hollandjg,
musslick,
chadcwilliams,
benwandrew,
TheLemonPig and
gtdang
Closed
benwandrew
reviewed
Jun 29, 2023
|
Weird... but they are not working on the website as they are now (../experimentalis/index.md) See here: https://autoresearch.github.io/autora/tutorials/ |
|
Or are the website links working for you? |
|
online I mean. Not locally. |
|
ah no, you're right. it's not working for me online as it originally was. happy to undo my commit and approve then as a temporary fix (at least to see what happens after merging this PR and rebuilding the site). |
benwandrew
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Delete as appropriate:
Questions (Optional)
the links in the jupiter notebooks work, but it doesn't seem right. I brievly looked into the mkdocs-jupiter plugin documentation but didn't find much. I'll work on it when I find time, but this is a quick fix so at least it works.