Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: test building before merge #486

Merged
merged 4 commits into from
Jun 23, 2023
Merged

docs: test building before merge #486

merged 4 commits into from
Jun 23, 2023

Conversation

hollandjg
Copy link
Member

Description

Fix a missing issue in the docs.
Add a check to ensure the documentation builds.

Type of change

  • docs: Documentation only changes
  • ci: Changes to our CI configuration files and scripts (i.e., those in the .github directory)

@hollandjg hollandjg changed the title Docs/test building before merge docs: test building before merge Jun 23, 2023
@hollandjg hollandjg marked this pull request as ready for review June 23, 2023 14:43
@hollandjg hollandjg enabled auto-merge June 23, 2023 14:43
younesStrittmatter
younesStrittmatter approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works locally!

@hollandjg hollandjg added this pull request to the merge queue Jun 23, 2023
Merged via the queue into main with commit f5371a9 Jun 23, 2023
@hollandjg hollandjg deleted the docs/test-building-before-merge branch June 23, 2023 14:48
benwandrew
benwandrew approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing the error i introduced, as well as enabling us to catch such errors more automatically going forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesStrittmatter younesStrittmatter younesStrittmatter approved these changes

@benwandrew benwandrew benwandrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hollandjg @benwandrew @younesStrittmatter