-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc/generalize tutorials #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a couple language edits in the theorist notebook and made a note about new experimentalist image, but otherwise this looks great!
"\n", | ||
"![Experimentalist](../img/experimentalist.png)\n", | ||
"\n", | ||
"Experimentalists may use information about candidate models $M$ obtained from a theorist,\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note: i think with the new image for the experimentalist (https://github.com/AutoResearch/autora/blob/doc/exp-module/docs/img/experimentalist.png), there is no longer direct correspondence from this language to M, X, Y in an image. not a big deal, just FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! Yes, I decided top drop the formal language; I think it overcomplicates things and is harder to track for consistency across the different module types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Description
I added general context for the main tutorials introducing an experimentalist and theorist.
Type of change
Remarks (Optional)