build: Torch 2.0.1 conditional dependency specification

[gtdang]

Description

Addressing issue #408

Type of change

• build: Changes that affect the build system or external dependencies (i.e., poetry, conda)

Features (Optional)

• bulleted list of features, describing the code contributions in this pull request

Questions (Optional)

• potential questions for the code reviewer (e.g., if you want feedback on a certain method or class; any feedback required from other code contributors with their mentioning)

[gtdang]

I removed fail-fast in the gh actions pytest workflow and confirmed that this issue is only for Linux builds.

[benwandrew]

i know we touched on this, but to confirm, is this just for now or more generally going forward? once we've got the conditional solution is there any reason we wouldn't revert to fail-fast?

[gtdang]

Yep! You got it! We're still in testing mode to figure out the right solution so we'll leave it off for now. But when we figure it out we'll switch this back to true. Fail-fast is a cost-saving feature, since you don't want keep running/paying for the compute resources for all the instances if one has failed. However it does obscure if the problem is isolated to one type of build vs across all builds.

[gtdang]

@benwandrew Wow! That was a battle but I got it working. So this is at least one solution. I'd like to get @hollandjg perspective on this when he's back next week. So lets wait to merge?

[benwandrew]

@benwandrew Wow! That was a battle but I got it working. So this is at least one solution. I'd like to get @hollandjg perspective on this when he's back next week. So lets wait to merge?

@gtdang sounds good, i agree. thanks for fighting your way through!

[hollandjg]

This should be a problem which is isolated to autora-theorist-darts once we've done the reorganization.
Is it just because torch 2.0.1 doesn't work on linux yet? If so, we can just keep the current working version 1.x until this is fixed.

[gtdang]

This should be a problem which is isolated to autora-theorist-darts once we've done the reorganization.
Is it just because torch 2.0.1 doesn't work on linux yet? If so, we can just keep the current working version 1.x until this is fixed.

It's actually because the the default for pip install behavior differs between operating systems. Linux defaults to a GPU version and you need to specify the CPU version whl source for it. For Mac and Windows it defaults to the CPU version. This is an issue for our tests because GH Runners don't have gpu. The build works but the test fails when searching to compile GPU modules.

I'm not sure when this change happened, but it the problem arose when trying to update to v2.0.1.

I brought this up at last week's maintenance meeting. We discussed that the CPU version should be the default dependency and have a warning about GPU resources when the user imports the Darts modules. I added an issue with more info to the autora-theorist-darts for this feature. AutoResearch/autora-theorist-darts#3

[hollandjg]

this needs to be closed here and moved over to the relevant subpackages which use pytorch (darts, falsification)