feat(controller): 8 - add command line interface for running on OSCAR #347
Conversation
This reverts commit 29da43c.
| _configure_logger(debug, verbose) | ||
| controller_ = _load_manager(manager) | ||
|
|
||
| _logger.debug(f"loading manager state from {directory=}") |
There was a problem hiding this comment.
What does the the = after the directory do?
There was a problem hiding this comment.
that prints "directory=<directory name>" which otherwise you'd have to print like: f"directory={directory}"
| def _configure_logger(debug, verbose): | ||
| if debug: | ||
| logging.basicConfig(level=logging.DEBUG) | ||
| _logger.debug("using DEBUG logging level") | ||
| if verbose: | ||
| logging.basicConfig(level=logging.INFO) | ||
| _logger.info("using INFO logging level") |
There was a problem hiding this comment.
Debug level would be deactivated by info level if both debug and verbose are True. Doing if verbose before if debug would make more sense. Debug is actually more verbose than info because it is a lower level than info. Therefore both info and debug statements would be logged at debug level. Because of this I find the argument names are a bit confusing for this function. A single argument for the logging level would be more simple. I've done this with enum as log levels are just encoded integers.
There was a problem hiding this comment.
I think you're right that a single argument would be better, and a single logging.basicConfig call. I'll include that in the next version
Co-authored-by: George Dang <[email protected]>
|
Too big, moving to new repo. |
Description
Add a command line interface for running AutoRA jobs.
Add examples showing how they can run asynchronously on Oscar using
cylc.If the issue is on Github, simply link to it using the '#' symbol; otherwise, provide a notion page link):
TODO:
plot_utilsto a separate PR refactor: remove outdated plot_utils for darts #350logging.basicConfigcalls into a single call.Type of change
Delete as appropriate:
Features (Optional)
Controllerin https://github.com/AutoResearch/autora/blob/feat/controller-cli/autora/controller/__main__.py andTheoristin https://github.com/AutoResearch/autora/blob/feat/controller-cli/autora/theorist/__main__.py.