Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Turn off Poetry modern installer #300

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

gtdang
Copy link
Collaborator

@gtdang gtdang commented Mar 21, 2023

This corrects an issue with an invalid debugpy wheel with Poetry v1.4.1 modern installer. This was causing an issue during GitHub action pytests package installation.

Description

Provide a high-level summary of the change and which issue (either on Github or Notion) is fixed. Please also include relevant motivation and context.

Fixes #(issue) (if the issue is on Github, simply link to it using the '#' symbol; otherwise, provide a notion page link)

Type of change:

  • Bug fix (non-breaking change which fixes an issue)

Features:

  • Updated GitHub action test-pytest.yml to turn Poetry's modern installer off.

Questions:

  • Do we need to do this for any other actions? Or add it to installation documentation.

…tion to false.

This correct an issue with and invalid debugpy wheel with Poetry v1.4.1 modern installer.
@gtdang gtdang requested a review from musslick as a code owner March 21, 2023 15:51
@gtdang gtdang requested review from hollandjg and benwandrew March 21, 2023 15:51
Copy link
Collaborator

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (for now?)!

@hollandjg
Copy link
Member

this is related to python-poetry/poetry#7686

Copy link
Collaborator

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good!

@gtdang
Copy link
Collaborator Author

gtdang commented Mar 23, 2023

@hollandjg Should we merge this or continue to wait?

@hollandjg hollandjg merged commit 46da0af into main Mar 24, 2023
@hollandjg hollandjg deleted the fix/poetry_installer branch March 24, 2023 14:47
@gtdang
Copy link
Collaborator Author

gtdang commented Apr 7, 2023

Been following this issue. Seems like Poetry updated so that it will warn invalid wheels instead of failing. This fix has been released with the Poetry 1.4.2 release.
python-poetry/poetry#7694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants