Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check all experimentalist samplers for model.predict() #650

Open
2 tasks done
musslick opened this issue Aug 8, 2024 · 1 comment
Open
2 tasks done

check all experimentalist samplers for model.predict() #650

musslick opened this issue Aug 8, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request. priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks.
Milestone

Comments

@musslick
Copy link
Collaborator

musslick commented Aug 8, 2024

make sure that the function call for predict is directly on the model (that it is compatible with rnn-theorist)

  • disagreement
  • falsification

Make sure that the predict method is called with a pandas data frame as input for the conditions. Make also sure to avoid prior conversion of conditions (use plain pandas input).

@musslick musslick self-assigned this Aug 8, 2024
@musslick musslick added the enhancement New feature or request. label Aug 8, 2024
@musslick musslick added this to the JOSS Revision milestone Aug 8, 2024
@musslick musslick added the priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks. label Aug 8, 2024
@younesStrittmatter
Copy link
Collaborator

younesStrittmatter commented Aug 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks.
Projects
None yet
Development

No branches or pull requests

2 participants