feat: add lmm to synthetic experiments #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesStrittmatter
requested review from
hollandjg,
musslick,
chadcwilliams,
benwandrew,
TheLemonPig,
blinodelka and
whyhardt
| # Process each part of the random effect (intercept and slopes) | ||
| for part in random_effects_.split('+'): | ||
| part = part.strip() | ||
| std_dev = random_effects[group_var].get(part, 0.5) |
There was a problem hiding this comment.
There is a bug here.
In the formula, you correctly define the intercept as 1, but then in your examples you define the intercept as Intercept.
For example,
formula = 'rt ~ 1 + (1|subject) + x1'
random_effects = {'subject': {'Intercept': .1}}
This line of code is looking for the key 1 in the random_effects dictionary, which does not exist. I am submitting a PR with a quick fix for this.
chadcwilliams
suggested changes
Dec 11, 2023
…el-to-abstract-CW 19 feat add linear mixed model to abstract cw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add linear mixed model synthetic runner
Type of change