feat: make synthetic runners use dataframes and rename inputs so stat… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also resolves AutoResearch/autora#561 |
benwandrew
requested changes
Aug 29, 2023
src/autora/experiment_runner/synthetic/psychophysics/weber_fechner_law.py
Outdated
Show resolved
Hide resolved
…hner_law.py Co-authored-by: benwandrew <[email protected]>
musslick
requested changes
Aug 30, 2023
| @@ -117,8 +119,8 @@ def experiment_runner(X: np.ndarray, added_noise_=added_noise): | |||
| probability_a = x[1] | |||
| probability_b = x[3] | |||
|
|
|||
| expected_value_A = value_A * probability_a + rng.normal(0, added_noise_) | |||
| expected_value_B = value_B * probability_b + rng.normal(0, added_noise_) | |||
| expected_value_A = value_A * probability_a + rng.normal(0, observation_noise) | |||
There was a problem hiding this comment.
Would call this value_noise which is specific to the expected utility theory instead of observation_noise
| @@ -113,8 +118,8 @@ def experiment_runner(X: np.ndarray, added_noise_=added_noise): | |||
| x[3] ** coefficient + (1 - x[3]) ** coefficient | |||
| ) ** (1 / coefficient) | |||
|
|
|||
| expected_value_A = value_A * probability_a + rng.normal(0, added_noise_) | |||
| expected_value_B = value_B * probability_b + rng.normal(0, added_noise_) | |||
| expected_value_A = value_A * probability_a + rng.normal(0, observation_noise) | |||
There was a problem hiding this comment.
Same here, I would call observation_noise instead value_noise
| Y = np.zeros((X.shape[0], 1)) | ||
| for idx, x in enumerate(X): | ||
| similarity_A1 = x[0] | ||
| similarity_A2 = x[1] | ||
| similarity_B1 = x[2] | ||
| similarity_B2 = x[3] | ||
|
|
||
| y = (similarity_A1 * focus + np.random.normal(0, added_noise_)) / ( | ||
| y = (similarity_A1 * focus + rng.normal(0, observation_noise)) / ( |
There was a problem hiding this comment.
I think here it is somewhat fine because we add it at the end and then normalize. You might still want to call it decision_noise because it is applied before the division.
…xperiment_runner to run
…ate' of https://github.com/AutoResearch/autora-synthetic into 9-chore-rename-input-arguments-of-runners-to-us-with-state
…me experiment_runner to run in new synthetic models/fixxed wrong input statements, added new models to test
benwandrew
reviewed
Sep 1, 2023
benwandrew
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e logic works