Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make pre-commit run #22

Merged
merged 1 commit into from
Nov 18, 2023
Merged

chore: make pre-commit run #22

merged 1 commit into from
Nov 18, 2023

Conversation

younesStrittmatter
Copy link
Collaborator

  • pre-commit-hooks run automatically
  • pre-commit-hooks pass

hollandjg
hollandjg reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

You may want to include a line on how to install the pre-commit hooks in either the README.md or (perhaps better) a new CONTRIBUTOR.md file, or make sure that that's documented somewhere in the parent package's documentation.

benwandrew
benwandrew approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me; nothing to add to John's comments

@younesStrittmatter younesStrittmatter merged commit f0c4254 into main Nov 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollandjg hollandjg hollandjg left review comments

@benwandrew benwandrew benwandrew approved these changes

@musslick musslick Awaiting requested review from musslick

@chadcwilliams chadcwilliams Awaiting requested review from chadcwilliams

@whyhardt whyhardt Awaiting requested review from whyhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@younesStrittmatter @hollandjg @benwandrew