-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new variant of the state object with a history #70
base: main
Are you sure you want to change the base?
Conversation
…e and the history extension
…standard fields and always replaces but keeps a history
…f the state object each time
This reverts commit 17efd9e.
… whose existence is required but value is unimportant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should keep this file and this object – it's a bit weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be the standard state we'd use with the history – it's the one which makes the most sense, I think. Although what do we do if a function needs multiple models? There's only one slot for a model here, so I'm not sure how we deal with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is the main change. It adds the History
and the State object which uses it: DeltaHistory
. There's a few examples and some testing in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are changes to the basic state adding so that we don't have to emit a warning if there's a field missing in the Delta, which may often be the case for metadata fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting notebook on examples.
Add a new variant of the state object with a history.
ToDos
Implementation
meta="raw"
ormeta="clean"
delta_to_state_transformed
– a new version of the wrapperdelta_to_state
which allows transforming the input State before passing it to the inner function, but adds the Delta to the original input State.delta_to_state
.@tag_delta
which adds a tag likemeta="filtered"
orcomponent="theorist"
to a Delta before passing it back to the caller.Documentation
Cleanups