refactor: make names of wrapper functions more generic #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollandjg
requested review from
younesStrittmatter,
benwandrew and
musslick
and removed request for
benwandrew
hollandjg
changed the base branch from
main
to
feat/default-state-from-main-experimentalists
benwandrew
reviewed
Jul 19, 2023
hollandjg
pushed a commit
that referenced
this pull request
Nov 29, 2023
docs: update license to MIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make more generic wrapper function names:
state_fn_from_estimatorstate_fn_from_x_to_y_fn_dfstate_fn_from_x_to_xy_fn_dfThe
experiment_runnerfunctions are at present only designed to work on dataframes which include column names – for numpy array support, we'd need new wrappers which also take into account thevariablesto validate the shape of the arrays returned.Relevant issues:
wrapperfunctions more generic #23Todos:
Doctests:
state_fn_from_estimatorstate_fn_from_x_to_y_fn_dfstate_fn_from_x_to_xy_fn_dfDeleted:
state_fn_from_pipeline(no longer compatible with StandardState, not clear that we need this or how exactly it should look)