Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pd.DataFrame, np.ndarray and np.recarray to random_sample #20

Closed

Conversation

hollandjg
Copy link
Member

No description provided.

Copy link
Contributor

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense, but it begs the question, what do we do with all the other experimentalists? I think we should not require them to be coded in the same way. Especially for outside contributors. Maybe there is a way to build wrappers that convert input to the input necesarry for the experimentalist and then back, so that other experimentalists also support all these datatypes?

@hollandjg
Copy link
Member Author

This makes a lot of sense, but it begs the question, what do we do with all the other experimentalists? I think we should not require them to be coded in the same way. Especially for outside contributors. Maybe there is a way to build wrappers that convert input to the input necesarry for the experimentalist and then back, so that other experimentalists also support all these datatypes?

Yes, that's a really good point. I'm not sure the best way to do that – what the overarching method should be to do that. I've done an additional example – the random_experimentalist using the state mechanism.

#21

We can look for the common code between those two, or see a better way to wrap them. Any ideas on what a good interface would look like? If we have a good interface (i.e. how the wrapper function should feel, and how the wrapped function should act) then we can work out how to implement it.

@hollandjg
Copy link
Member Author

superseded by #28

@hollandjg hollandjg closed this Jul 10, 2023
hollandjg added a commit that referenced this pull request Nov 29, 2023
…pler-sample

test: update docs for model disagreement sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants