-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add arguments for model parameters #10
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 95.41% 95.83% +0.42%
==========================================
Files 3 3
Lines 109 120 +11
==========================================
+ Hits 104 115 +11
Misses 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me. I can't fully comment on actual mlflow implementation however. If all works, I believe it's good 😬
temperature, top_k and top_n
parameters for both eval and generation pipelines (function -> CLI -> .yml workflow)