Add check for default Windows location if location is off #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will check this later, thanks |
|
@XRicko are the changes you made tested? |
I've been using it since I made changes and it works. So I guess tested? |
|
Beautiful, thank you. I'll take a look at integrating this later today or tomorrow if nothing goes wrong. |
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen some issues where people don't want to turn on location only for this app and they'd like to enter it. Even though I believe that you don't use my location for other purposes, I'd like to keep it off. With this change you can set default location in Windows settings and app will use it. May be helpful. What do you think?