Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Dark Mode changes only Windows mode and resets wallpaper and accent color #547

Closed
ZMYaro opened this issue Oct 11, 2022 · 11 comments
Closed
Labels
bug Something isn't working

Comments

@ZMYaro
Copy link

ZMYaro commented Oct 11, 2022

Description

Recently, when Auto Dark Mode changes my theme to dark, it has been switching the Windows mode to dark, but the app mode is light. It also changes my wallpaper to solid black and my theme color to gray. So far, it seems to stop happening when I disable ADM, so I am inclined to think it is ADM causing it, and not only an issue in Windows, but I am on the Windows and ADM beta channels.

Expected Behavior

No response

Log Data

service.log
config.yaml

Operating System

Version 22H2 build 22623.741

Commit Hash and Version

  • Commit: 69a0702
  • Service: 10.3.0.31
  • Updater: 2.5.1
  • App: 10.0.1.0
  • Shell: 1.3.1.0
  • .Net: 6.0.7

Screenshots

No response

@ZMYaro ZMYaro added the bug Something isn't working label Oct 11, 2022
@Spiritreader
Copy link
Member

Spiritreader commented Oct 11, 2022

Thanks for turning this into a separate issue.

As I mentioned in the other thread I would require some more data to look into this.

Which would be:

  • the debug mode enabled
  • and you setting up your theme / desktop while auto dark Mode is off and then posting the full theme file here. (C:\Users\ZMYaro\AppData\Local\Microsoft\Windows\Themes\Custom.theme)
  • Then start ADM, switch the theme such that your broken state appears (black screen, wrong app color) and post the them file found under C:\Users\ZMYaro\AppData\Local\Microsoft\Windows\Themes\ADMTheme.theme

The logs with debug enabled will reveal what theme is applied during synchronization, and once I have the theme file I can attempt to reproduce the issue.
Thanks


Updates:

First log analysis has revealed that we need this theme here:

2022-10-10 20:56:32 | Debug | ThemeFile.SyncActiveThemeData: currently active theme: Unsaved Theme, path: C:\Users\ZMYaro\AppData\Local\Microsoft\Windows\Themes\Custom.theme 

That's the point where the synchronization starts to fail

Also, it's very important that once you have set up your theme, you click on the themes section in the system settings once, otherwise the Custom.theme won't update
image

@albertopasqualetto
Copy link
Contributor

That also happens to me.

  1. Default theme: Roamed.theme.txt
  2. Theme forced dark with ADM
  3. Theme non-forced dark with ADM
  4. Custom theme corrected while ADM on light mode:Custom.theme.txt
  5. Theme forced dark with ADM. ADMTheme: ADMTheme.theme.txt

Config: config.yaml.txt
Debug logs: service.log

@Spiritreader
Copy link
Member

Spiritreader commented Oct 12, 2022

That also happens to me.

  1. Default theme: Roamed.theme.txt
  2. Theme forced dark with ADM
  3. Theme non-forced dark with ADM
  4. Custom theme corrected while ADM on light mode:Custom.theme.txt
  5. Theme forced dark with ADM. ADMTheme: ADMTheme.theme.txt

Config: config.yaml.txt Debug logs: service.log

The custom.theme you posted has no wallpaper set,

[Control Panel\Desktop]
Wallpaper=
Pattern=
MultimonBackgrounds=0
PicturePosition=4

Auto Dark Mode takes the wallpaper from the Custom.theme file (if no other named theme is active), so if it's not there, it can't display it.

  1. Do you use the windows spotlight wallpaper feature?
    Windows Spotlight is currently unsupported and it is unclear when Microsoft includes that in the .theme file

  2. Also, logs indicate you have a Roamed.theme active
    path: C:\Users\alber\AppData\Local\Microsoft\Windows\Themes\Roamed.theme
    Please also provide the content for that one

@albertopasqualetto
Copy link
Contributor

@Spiritreader I already posted my Roamed.theme, and also that has not a background set.
My background is a solid green one from windows's selector.
I see that today light mode was set with ADMTheme (and black background).

@Spiritreader
Copy link
Member

Oh sorry I some how missed that, am a bit in a hurry lately.
I know what's happening now, the section that parsed the background does not get read properly. That shouldn't be too hard to fix, I'll update you with a new beta build as soon as I've looked at the code responsible for reading the background color.

Spiritreader added a commit that referenced this issue Oct 13, 2022
- feat: theme auto notify delay toast on adm/system startup
- improvement: less calls necessary for active theme sync
- improvement: wallpaper synchronization vastly improved
- improvement: wallpaper and solid color state now fetched during the enable hook (reduces unnecessary theme applications on startup)
- change: new SwitchEvent: Api (for calls that shouldn't invoke notifications)
- fix: fix issue with solid color not being synced (#547)
- fix: theme picker page always forcing a theme refresh on load theme when it's disabled
- fix: system resume/unlock theme refreshes not respecting auto-pauses
- fix: update remaining theme path refresh methods to use the newer theme syncing
- fix: incorrect initial themes when launching ADM with empty theme paths in theme mode
@Spiritreader
Copy link
Member

@albertopasqualetto I've pushed a new beta build (10.0.1.38) which addresses your issue and should also lessen the number of cases where ADM incorrectly set a black wallpaper

@amitaba
Copy link

amitaba commented Oct 15, 2022

Same issue: I had a dark gray solid background, now as soon as Dark mode switches on the background is set to Black. Latest build running on Windows11Pro x64 22H2.

@Spiritreader
Copy link
Member

Same issue: I had a dark gray solid background, now as soon as Dark mode switches on the background is set to Black. Latest build running on Windows11Pro x64 22H2.

I assume you are on the latest beta now, please post your log and config file again so I can take a look.
I am unable to reproduce this on 10.3.0.46.

solidcolor.mp4

Spiritreader added a commit that referenced this issue Oct 17, 2022
@amitaba
Copy link

amitaba commented Oct 18, 2022

I cannot find beta 10.3.0.46 - I have set Beta channel in Settings, clicked on Check for Updates, it keeps saying 10.2... is latest build. I have searched the repo but cannot find a beta channel for installs, only the current (11 builds) for release versions.

@Spiritreader
Copy link
Member

Spiritreader commented Oct 18, 2022

I cannot find beta 10.3.0.46 - I have set Beta channel in Settings, clicked on Check for Updates, it keeps saying 10.2... is latest build. I have searched the repo but cannot find a beta channel for installs, only the current (11 builds) for release versions.

Usually we have this sort of report from people that live in China, as the gfw blocks raw.githubusercontent.

You can find and download builds manually here.
https://github.com/AutoDarkMode/AutoDarkModeVersion/releases

@Spiritreader
Copy link
Member

Wallpaper resets have been addressed in 10.3 as best as possible.
There are still a few limitations that might cause this behavior, please see our list of known limitations here:
https://github.com/AutoDarkMode/Windows-Auto-Night-Mode/wiki/Known-limitations

if you feel like none of these conditions apply, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants