Upgrade parity to 1.9.7 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahZoltu
reviewed
May 2, 2018
| @@ -52,7 +54,7 @@ disable = true | |||
|
|
|||
| [ipfs] | |||
| # You won't be able to hash-query blockchain data. | |||
| disable = true | |||
| enable = false | |||
There was a problem hiding this comment.
Comment above is now incorrect.
There was a problem hiding this comment.
The comment remains true, they just changed the nature of the variable
MicahZoltu
reviewed
May 2, 2018
| @@ -26,7 +28,7 @@ reserved_only = true | |||
| # JSON-RPC will be listening for connections on IP 0.0.0.0. | |||
| interface = "all" | |||
| # Allows Cross-Origin Requests from domain '*'. | |||
| cors = "*" | |||
| cors = ["*"] | |||
There was a problem hiding this comment.
Did the syntax change in 1.9.7, or was this wrong before?
There was a problem hiding this comment.
MicahZoltu
reviewed
May 2, 2018
| @@ -52,7 +54,7 @@ disable = true | |||
|
|
|||
| [ipfs] | |||
| # You won't be able to hash-query blockchain data. | |||
| disable = true | |||
| enable = false | |||
There was a problem hiding this comment.
Same as above, comment needs to be updated. Also, I'm curious what this actually does...
There was a problem hiding this comment.
I read a tiny bit about it, it's like since ethereum stuff is all hashes, you can export those via IPFS and serve up ethereum data via ipfs for... reasons.
MicahZoltu
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.