Sync latest changes from master fork to client branch #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Initial DK Catalog Setup
## Overview
This pull request introduces the initial setup for the DK catalog. It
includes the `catalog-info.yaml` file for integrating our services with
the DK, facilitating better visibility and management of our software
components.
## Changes
- Added `catalog-info.yaml` with the necessary metadata for our VTEX
services.
- Configured annotations for GitHub, Grafana, and TechDocs integration.
- Defined essential fields such as `type`, `lifecycle`, `owner`,
`system`.
## Purpose
The integration into DK software catalog aims to improve the
discoverability, documentation, and management of our software
components. It allows for a more centralized and organized view of our
system architecture.
## Requested Action
### Review:
Please review the contents of the `catalog-info.yaml` for accuracy and
completeness.
### Tech Docs Pipeline Setup:
If this repository contains docs that you want shown at your
Component/System page add the following Pipeline to your
`.vtex/deployment.(json|yaml)` file:
```yaml
- name: techdocs-v1
parameters:
entityReference: default/<component or system>/<your entity name> # add your entity type and name here
sourceDir: ./
when:
- event: push
source: branch
regex: main # configure with your repository's default branch
path:
- "docs/*" # this will make sure this pipeline is triggered only when the `docs` directory is changes. If you use another directory to store your docs, change this.
```
Check the complete Pipeline
[documentation](https://github.com/vtex/dk-cicd-hub/blob/main/docs/pipelines/techdocs-v1.md)
for more custom options.
### Feedback:
Suggestions for additional metadata or modifications to existing fields.
### Approval:
Once reviewed and agreed upon, approval for merge.
## Impact
- **Visibility**: Enhanced visibility of our services within the
organization.
- **Documentation**: Better linkage to our documentation and monitoring
tools.
- **Collaboration**: Easier for teams to find and understand
dependencies and relationships between services.
## Additional Notes
- This is part of an ongoing effort to document and manage our software
architecture more effectively.
- Further iterations may include additional annotations and refinements
as our usage of DK evolves.
---
Thank you for contributing to improving our software infrastructure!
Co-authored-by: dk-portal[bot] <134092483+dk-portal[bot]@users.noreply.github.com>
#### What problem is this solving? The app has problems with pushing view_cart pixel event when variant="drawer". This problem happens because of the wrong logic of handling open/close state of the Drawer component. It switches isOpen from true to false and back when user presses on the Cart Button in the store front header: 1. User presses on the Cart button --> isOpen changes to true --> view_cart event is pushed; 2. User presses on the close Drawer button --> nothing changed; 3. User presses on the Cart button --> isOpen changed to false --> view_cart event is not pushed because isOpen state == false. To solve this wrong behavior I added onVisibilityChanged callback function as a property argument to the Drawer component in the drawer app and made these changes in the minicart app to handle open/close events properly. #### How to test it? In the browser inspector console tab type dataLayer to see events that have been pushed. It should add view_cart event on every Drawer opening and when user adds a new product to the cart (at the moment when Drawer is opening) https://devalex--dunnesstorespreprod.myvtex.com/ #### Screenshots or example usage: https://github.com/user-attachments/assets/aff7f680-d649-452a-8837-30242f287454 https://github.com/user-attachments/assets/adeb1c36-71e8-45ca-8778-e6e9e3a419d6  #### Related PR vtex-apps/drawer#75
…quantity in minicart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
How to test it?
[Workspace](Link goes here!)
Screenshots or example usage:
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)