Skip to content

Commit

Permalink
Implementare feedback cr
Browse files Browse the repository at this point in the history
  • Loading branch information
SpanacheNarcis committed Nov 22, 2023
1 parent 3ca2600 commit ecc618a
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 1,148 deletions.
1,132 changes: 1 addition & 1,131 deletions CHANGELOG.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The Minicart is a block that displays a summary list of all items added to the s

```json
"dependencies": {
"vtex.minicart": "2.x"
"auchan.minicart": "2.x"
}
```

Expand Down
6 changes: 3 additions & 3 deletions manifest.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"vendor": "vtex",
"vendor": "auchan",
"name": "minicart",
"title": "Mini Cart",
"version": "2.67.1",
"version": "0.0.1",
"builders": {
"messages": "1.x",
"store": "0.x",
Expand All @@ -14,6 +14,7 @@
"postreleasy": "vtex publish --verbose"
},
"dependencies": {
"auchan.product-list": "0.x",
"vtex.product-summary": "2.x",
"vtex.store-resources": "0.x",
"vtex.store-components": "3.x",
Expand All @@ -26,7 +27,6 @@
"vtex.css-handles": "1.x",
"vtex.order-manager": "0.x",
"vtex.order-items": "0.x",
"vtex.product-list": "0.x",
"vtex.device-detector": "0.x",
"vtex.store-drawer": "0.x",
"vtex.checkout-summary": "0.x",
Expand Down
3 changes: 2 additions & 1 deletion messages/context.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@
"store/minicart.checkout-failure": "Message showed when there is a problem to a request to the server.",
"store/minicart.go-to-checkout": "Go to checkout",
"store/minicart.empty-state": "store/cart.empty-state",
"store/minicart.title": "store/cart.empty-state"
"store/minicart.title": "store/cart.empty-state",
"store/checkout-summary.Packaging": "store/checkout-summary.Packaging"
}
3 changes: 2 additions & 1 deletion messages/ro.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@
"store/minicart.checkout-failure": "A apărut o eroare. Te rugăm să încerci din nou.",
"store/minicart.go-to-checkout": "Finalizează comanda",
"store/minicart.empty-state": "Coșul tău de cumpărături este gol.",
"store/minicart.title": "Coș de cumpărături"
"store/minicart.title": "Coș de cumpărături",
"store/checkout-summary.Packaging": "Taxa de ambalare"
}
3 changes: 1 addition & 2 deletions react/Summary.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { OrderForm as OrderFormComponent } from 'vtex.order-manager'
import { useCssHandles, CssHandlesTypes } from 'vtex.css-handles'

import { fetchWithRetry } from './legacy/utils/fetchWithRetry'
import { PackagesSkuIds } from './typings/packages-sku-ids'

const CSS_HANDLES = ['minicartSummary'] as const

Expand Down Expand Up @@ -63,7 +62,7 @@ const Summary: FC<Props> = ({ classes }) => {
const totalizerItems = newTotalizers.find((t: any) => t.id === 'Items')

newTotalizers.push({
id: 'Fleg',
id: 'Packaging',
name: 'Taxa ambalare',
value: flegValue,
__typename: 'Totalizer',
Expand Down
1 change: 0 additions & 1 deletion react/components/MinicartIconButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { useMinicartCssHandles } from './CssHandlesContext'
import { useMinicartDispatch, useMinicartState } from '../MinicartContext'
import useCheckout from '../modules/checkoutHook'
import { fetchWithRetry } from '../legacy/utils/fetchWithRetry'
import { PackagesSkuIds } from '../typings/packages-sku-ids'

export const CSS_HANDLES = [
'minicartIconContainer',
Expand Down
6 changes: 3 additions & 3 deletions react/legacy/utils/fetchWithRetry.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { PackagesSkuIds } from '../typings/packages-sku-ids'

type FetchWithRetry = (url: string, retries: number) => Promise<PackagesSkuIds>
interface FetchWithRetry {
(url: string, retries: number): Promise<PackagesSkuIds>
}

export const fetchWithRetry: FetchWithRetry = (url: string, retries: number) =>
fetch(url)
Expand Down
6 changes: 2 additions & 4 deletions react/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vtex.minicart",
"version": "2.67.1",
"name": "auchan.minicart",
"version": "0.0.1",
"description": "A MiniCart Component.",
"scripts": {
"pretest": "yarn",
Expand All @@ -25,11 +25,9 @@
"vtex.css-handles": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.css-handles",
"vtex.device-detector": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.device-detector",
"vtex.flex-layout": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.flex-layout",
"vtex.minicart": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.minicart",
"vtex.order-items": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.order-items",
"vtex.order-manager": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.order-manager",
"vtex.pixel-manager": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.pixel-manager",
"vtex.product-list": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.product-list",
"vtex.product-summary": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.product-summary",
"vtex.react-portal": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.react-portal",
"vtex.render-runtime": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.render-runtime",
Expand Down
2 changes: 1 addition & 1 deletion react/typings/packages-sku-ids.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export type PackagesSkuIds = {
interface PackagesSkuIds {
data: {
bioFlegBagId: string
insulationBagId: string
Expand Down

0 comments on commit ecc618a

Please sign in to comment.