refactor: button 컴포넌트 인터랙션 추가 (#ATR-603)

Atractorrr · Sep 6, 2024 · 11419ff · 11419ff
1 parent c34b24e
commit 11419ff
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/design-system/packages/core/src/components/button/Button.tsx b/packages/design-system/packages/core/src/components/button/Button.tsx
@@ -17,10 +17,9 @@ interface ButtonProps
 }
 
 const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
-  ({ type, className, variant, color, size, round, square, ...props }, ref) => (
+  ({ className, variant, color, size, round, square, ...props }, ref) => (
     <button
-      // eslint-disable-next-line react/button-has-type
-      type={type || 'button'}
+      type="button"
       className={cn(
         buttonVariants({
           variant,

diff --git a/packages/design-system/packages/core/src/components/button/_index.scss b/packages/design-system/packages/core/src/components/button/_index.scss
@@ -32,6 +32,9 @@
   &:active {
     background-color: variable.$ds-gray-100;
   }
+  &:active {
+    transform: translateY(4%);
+  }
   .dark &:focus,
   .dark &:hover,
   .dark &:active {
@@ -43,6 +46,9 @@
     background-color: variable.$ds-gray-000;
     cursor: not-allowed;
   }
+  &:disabled:active {
+    transform: none;
+  }
   .dark &:disabled {
     color: variable.$ds-gray-500;
     border-color: variable.$ds-gray-800;

diff --git a/packages/design-system/packages/core/src/core/index.ts b/packages/design-system/packages/core/src/core/index.ts
@@ -1,3 +1,3 @@
-export * from './utils'
+// export * from './utils'
 export * from './overlay'
 export type * from './types'