This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Fixing bug where the worker thread would hang if there wasn't a tslint.json file #160
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5d9fe7b
Fixing bug where the worker thread would hang if there wasn't a tslin…
Xapphire13 07b5725
Logging worker error to console. Making specs async.
Xapphire13 6601b34
Adding note about 'fit'. Adding check for 'configurationPath'
Xapphire13 bbbfe43
Merge branch 'master' of https://github.com/AtomLinter/linter-tslint …
Xapphire13 52490b3
Merging master
Xapphire13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
const foo = 42; | ||
export default foo; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,9 @@ | |
|
||
import * as path from 'path'; | ||
|
||
const validPath = path.join(__dirname, 'fixtures', 'valid', 'valid.ts'); | ||
const invalidPath = path.join(__dirname, 'fixtures', 'invalid', 'invalid.ts'); | ||
const noConfigPath = path.join(__dirname, 'fixtures', 'no-config', 'noConfig.ts'); | ||
const validPath = path.join(__dirname, 'fixtures', 'valid', 'valid.ts'); | ||
|
||
describe('The TSLint provider for Linter', () => { | ||
const lint = require('../lib/main.js').provideLinter().lint; | ||
|
@@ -47,4 +48,10 @@ describe('The TSLint provider for Linter', () => { | |
}), | ||
); | ||
}); | ||
|
||
it('validates even when there is no tslint.json', () => { | ||
waitsForPromise(() => | ||
atom.workspace.open(noConfigPath).then(editor => lint(editor)), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the results be checked? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not really sure. In this test I don't care that the file was accurately validated, nor the specific results, I just want to make sure that validation completed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If that's all that was needed for the test, that's good enough for me. |
||
); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't something be done with this crash? (Logging to the console?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will add =]