This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Refactored to perform linting/fixing on async worker task #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcanemagus
suggested changes
Apr 20, 2017
| this.worker = new Task(require.resolve('./worker.js')); | ||
| idleCallbacks.delete(createWorkerCallback); | ||
| }); | ||
| idleCallbacks.add(createWorkerCallback); | ||
| }, | ||
|
|
||
| deactivate() { |
There was a problem hiding this comment.
You'll need to terminate your worker here in deactivate().
lib/main.js
Outdated
| if (filePath === null || filePath === undefined) { | ||
| return null; | ||
| } | ||
| const text = textEditor.getText(); |
There was a problem hiding this comment.
Move this below the worker initialization check so the "conflict window" is as small as possible.
lib/worker.js
Outdated
| } | ||
| } else { | ||
| const { emitKey, jobType, content, filePath } = message.message; | ||
| const options = jobType === 'fix' ? { |
There was a problem hiding this comment.
Just put this all on one line, there's only the one option.
lib/worker.js
Outdated
|
|
||
| function loadDefaultTSLint() { | ||
| if (!tslintDef) { | ||
| tslintDef = require('loophole').allowUnsafeNewFunction(() => |
There was a problem hiding this comment.
Do we actually need the loophole here? I'm not sure that Atom's CSP actually applies to Task processes.
There was a problem hiding this comment.
No idea (since this part was simply moving the methods). I shall try, then get back to you =]
Arcanemagus
approved these changes
Apr 24, 2017
This was referenced Apr 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosely based on @Arcanemagus's work on eslint/task-api
Caveats