-
Notifications
You must be signed in to change notification settings - Fork 140
Conversation
Filed atom/atom#14300 about the overhead from utilizing this. I still feel this is the direction we should go as it massively simplifies the code base, and the overhead there is coming from Atom itself. |
724ffe1
to
bf275c7
Compare
5b191a2
to
4eb69e8
Compare
Looks like Travis-CI and AppVeyor didn't like the base branch change, attempting a close/re-open. |
I think the AppVeyor failure is due to atom/ci#66, will update to my test version of the script to check. |
Hmm, that fixes the usage of the system node for installing the dev modules, but it's still failing as if it can't find the |
Atom v1.13.0 introduced support for package's defining their own transpilation pipeline. Utilize this to remove the transpiled code from the repo and let Atom generate it on the fly.
8ccacb9
to
ff236f1
Compare
AppVeyor seems to have had a temporary issue causing the build to fail for a reason that should be completely out of their control, but changing nothing here has caused it to work properly. On the plus side, I found that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work great, and you've gotta love that line count diff! This will greatly improve the dev experience working in this package, not worrying about running the compiler and checking in compiled code.
Big 👍 from me.
Atom v1.13.0 introduced support for package's defining their own transpilation pipeline. Utilize this to remove the transpiled code from the repo and let Atom generate it on the fly.
NOTE: Based on the Task API branch, will need rebasing once #889 gets merged into
master
!Fixes #857.