Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Supress warnings about the current file being ignored by eslint #670

Conversation

broberson
Copy link
Contributor

Addresses #669

@IanVS
Copy link
Member

IanVS commented Aug 13, 2016

Thanks, while you're at it, could you also add

'File ignored by default. Use "--ignore-pattern '!node_modules/*'" to override'

and

'File ignored by default. Use "--ignore-pattern '!bower_components/*'" to override'

?

That should cover all the permutations on the ESLint default ignore messages.

@broberson
Copy link
Contributor Author

Happy to. Thanks Ian.

@broberson
Copy link
Contributor Author

CircleCI doesn't like that eslint's warning message is over 100 characters, but splitting it into multiple strings to make a bot happy just felt wrong. I can do that though, if you're a stickler for green checkmarks.

@Arcanemagus
Copy link
Member

Arcanemagus commented Aug 15, 2016

@broberson The style checks are in there for a reason 😉.

Split the line up, run npm run compile again (it's currently out of date) and we'd love to merge this, thanks for putting this together!

I can't wait till we can merge in ESLint v3 where that's just a flag on the message...

@broberson
Copy link
Contributor Author

There you go. Thanks :)

@IanVS IanVS merged commit 406776b into AtomLinter:master Aug 16, 2016
@IanVS
Copy link
Member

IanVS commented Aug 16, 2016

Thanks @broberson!

@broberson broberson deleted the supress_warning_about_files_ignored_by_default branch August 16, 2016 03:38
@broberson broberson restored the supress_warning_about_files_ignored_by_default branch August 16, 2016 03:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants