-
Notifications
You must be signed in to change notification settings - Fork 140
Interpolate env var in conf path #297
Interpolate env var in conf path #297
Conversation
* Interpolate environment variables in the provided path for the eslint config file Closes AtomLinter#291
While what you did looks nice, I wouldn't trust a module who is not popular and we don't even know it's author, what if he doesn't follow semver and breaks the API? I would highly recommend we pin the version of it or find an alternative package that is more trust worthy |
The entire code for the module appears to be 15 lines :-) |
I really doubt that will be an issue given that the author has many packages (https://www.npmjs.com/~linusu) and is a member on @expressjs (https://github.com/LinusU) @LinusU, can you comment on following semver in your projects? |
RE: LOC - sindresorhus/ama#10 (comment) |
@SpainTrain ... Agreed ... I was thinking more about risk in relation to (hidden) complexity ... |
oh gotcha! 👍 |
I promise to follow semver, which I do with all of my modules :) I also fullheartedly agree with sindresorhus/ama#10 (comment) and I'm usually very fast at responding to bug reports. |
Thanks for responding! @steelbrain are we good to merge? |
…g-path Interpolate env var in conf path
Awesome 👍 |
@LinusU Thank you for a nice package! 👍 |
Published in v5.2.1. |
Thanks all 👍 |
Closes #291