Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Add specs for showRuleIdInMessage #473

Closed
Arcanemagus opened this issue Mar 8, 2016 · 4 comments
Closed

Add specs for showRuleIdInMessage #473

Arcanemagus opened this issue Mar 8, 2016 · 4 comments

Comments

@Arcanemagus
Copy link
Member

We aren't currently testing the results of toggling showRuleIdInMessage.

@granteagon
Copy link
Contributor

@Arcanemagus Happy to help implement this if help is wanted.

@steelbrain
Copy link
Contributor

@granteagon We'd be happy to review a PR if you wanna help :)

@granteagon
Copy link
Contributor

👍🏼It's on my todo list!

@Arcanemagus
Copy link
Member Author

Turns out the reason they weren't showing as HTML currently was that the package wasn't getting activated, so the defaults weren't being set. This has been fixed now, but there should still be a spec testing the option controlling that if we are going to keep the option.

@Arcanemagus Arcanemagus changed the title Add specs for html messages Add specs for showRuleIdInMessage May 19, 2017
Arcanemagus added a commit that referenced this issue May 19, 2017
Add a spec testing that the "Show Rule ID in Messages" option works as
expected.

Fixes #473.
Arcanemagus added a commit that referenced this issue May 22, 2017
Add a spec testing that the "Show Rule ID in Messages" option works as
expected.

Fixes #473.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants