This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 140
Add specs for showRuleIdInMessage #473
Comments
@Arcanemagus Happy to help implement this if help is wanted. |
@granteagon We'd be happy to review a PR if you wanna help :) |
👍🏼It's on my todo list! |
Turns out the reason they weren't showing as HTML currently was that the package wasn't getting activated, so the defaults weren't being set. This has been fixed now, but there should still be a spec testing the option controlling that if we are going to keep the option. |
Arcanemagus
changed the title
Add specs for html messages
Add specs for showRuleIdInMessage
May 19, 2017
Arcanemagus
added a commit
that referenced
this issue
May 19, 2017
Add a spec testing that the "Show Rule ID in Messages" option works as expected. Fixes #473.
Arcanemagus
added a commit
that referenced
this issue
May 22, 2017
Add a spec testing that the "Show Rule ID in Messages" option works as expected. Fixes #473.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We aren't currently testing the results of toggling
showRuleIdInMessage
.The text was updated successfully, but these errors were encountered: