Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the way a string of an user is resolved #301

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Jul 8, 2018

Description

When Remove-JiraGroupMember uses a [String] for -User, Get-JiraUser does not resolve properly resolve the input.
This is fixed by using -UserName instead of -InputObject on Get-JiraUser

Motivation and Context

closes #299

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau lipkau self-assigned this Jul 8, 2018
@lipkau lipkau requested review from a team as code owners July 8, 2018 13:52
@ghost ghost added the Status:In Review label Jul 8, 2018
@lipkau lipkau force-pushed the fix/#299-ResolveUserString branch from e189b60 to 3e8160b Compare July 8, 2018 16:49
Copy link

@FriedrichWeinmann FriedrichWeinmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@lipkau lipkau merged commit b1f3ca1 into AtlassianPS:master Jul 9, 2018
@ghost ghost removed the Status:In Review label Jul 9, 2018
@lipkau lipkau deleted the fix/#299-ResolveUserString branch July 9, 2018 17:47
@lipkau lipkau mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove-JiraGroupMember fails
2 participants