Improve error-handler to accommodate for ErrorDetails and non-JSON/HTML responses #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
One of the things that may need additional refinement (probably in a separate PR) is how to handle non-JSON/HTML error responses.
|
(as Test-ServerResponse requires it)
|
@lipkau The |
lipkau
approved these changes
Jun 2, 2018
Merged
lipkau
added a commit
that referenced
this pull request
Jun 28, 2018
### IMPROVEMENTS - Added support for paginated response from API server by means of `-Paging` (#291, [@lipkau[]]) - Added full set of functions to manage Filter Permissions (#289, [@lipkau[]]) - Added `-Id` parameter to `Remove-JiraFilter` (#288, [@lipkau[]]) - Changed logic of `Get-JiraUser` to return multiple results for a search (#272, [@lipkau[]]) - Added posts for homepage to the module's repository (#268, [@lipkau[]]) - Improved handling of _Credentials_ (#271, [@lipkau[]]) - Added missing interactions with _Filters_ (#266, [@lipkau[]]) - Added `Remove-JiraIssue` (#265, [@hmmwhatsthisdo[]]) - Improved Build script (to deploy changes to the homepage) (#259, [@lipkau[]]) ### BUG FIXES - Reverted `Add-JiraIssueAttachament` as JiraPS v2.7 broke it (#287, [@lipkau[]]) - Fixed resolving of Remote Link (#286, [@lipkau[]]) - Improved error handling for ErrorDetails and non-JSON/HTML responses (#277, [@hmmwhatsthisdo[]]) - Fully support Powershell v3 (#273, [@lipkau[]]) - Fixed parameter used in documentation but not in code (#263, [@lipkau[]])
lipkau
added a commit
that referenced
this pull request
Jun 29, 2018
### IMPROVEMENTS - Added support for paginated response from API server by means of `-Paging` (#291, [@lipkau[]]) - Added full set of functions to manage Filter Permissions (#289, [@lipkau[]]) - Added `-Id` parameter to `Remove-JiraFilter` (#288, [@lipkau[]]) - Changed logic of `Get-JiraUser` to return multiple results for a search (#272, [@lipkau[]]) - Added posts for homepage to the module's repository (#268, [@lipkau[]]) - Improved handling of _Credentials_ (#271, [@lipkau[]]) - Added missing interactions with _Filters_ (#266, [@lipkau[]]) - Added `Remove-JiraIssue` (#265, [@hmmwhatsthisdo[]]) - Improved Build script (to deploy changes to the homepage) (#259, [@lipkau[]]) ### BUG FIXES - Reverted `Add-JiraIssueAttachament` as JiraPS v2.7 broke it (#287, [@lipkau[]]) - Fixed resolving of Remote Link (#286, [@lipkau[]]) - Improved error handling for ErrorDetails and non-JSON/HTML responses (#277, [@hmmwhatsthisdo[]]) - Fully support Powershell v3 (#273, [@lipkau[]]) - Fixed parameter used in documentation but not in code (#263, [@lipkau[]])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies
Invoke-JiraMethodto improve error-parsing under certain conditions.More specifically, the following changes have been made:
ErrorDetailsfield on the associated exception. (see Error handling does not function correctly if Invoke-WebRequest exceptions contain ErrorDetails #276)errorMessagesproperty versus theerrorsproperty.Motivation and Context
If Jira (or the web server/proxy used to access it) is using Chunked transfer encoding, for instance, this field may not be populated (see this PowerShell UserVoice post).
This PR resolves #276.
Types of changes
Checklist: