Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Convert::ToInt with explicite casting #166

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Replace Convert::ToInt with explicite casting #166

merged 1 commit into from
Mar 27, 2019

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Mar 27, 2019

Description

Replaced incorrect usage of [Convert]::ToInit() with explicit casting to [UInt32].

Motivation and Context

closes #165

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau lipkau self-assigned this Mar 27, 2019
@lipkau lipkau requested review from a team as code owners March 27, 2019 12:27
@ghost ghost added the Status:In Review label Mar 27, 2019
@lipkau lipkau added this to the v2.5 milestone Mar 27, 2019
@lipkau lipkau force-pushed the fix/165-FixConversionToInt branch from 9c48cdf to b21a03c Compare March 27, 2019 12:50
brianbunke
brianbunke approved these changes Mar 27, 2019
View reviewed changes
Copy link
Collaborator

@brianbunke brianbunke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lipkau lipkau merged commit 93e7663 into AtlassianPS:develop Mar 27, 2019
@ghost ghost removed the Status:In Review label Mar 27, 2019
@lipkau lipkau deleted the fix/165-FixConversionToInt branch March 27, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianbunke brianbunke brianbunke approved these changes

Assignees

@lipkau lipkau

Labels
Area:Module Issue:Bug
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@lipkau @brianbunke