Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-User #109 #160

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Get-User #109 #160

wants to merge 3 commits into from

Conversation

Dejulia489
Copy link

@Dejulia489 Dejulia489 commented Dec 21, 2018

Description

Get-User

Motivation and Context

Closes #109

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@Dejulia489 Dejulia489 requested review from a team as code owners December 21, 2018 22:18
@ghost ghost assigned Dejulia489 Dec 21, 2018
@ghost ghost added the Status:In Review label Dec 21, 2018
@lipkau lipkau changed the base branch from master to develop December 21, 2018 22:49
@lipkau
Copy link
Member

lipkau commented Dec 21, 2018

Looks like you forgot a documentation file ;-)

@Dejulia489
Copy link
Author

Doc has been added

@lipkau
Copy link
Member

lipkau commented Dec 28, 2018

@Dejulia489 : I sent a PR to you (link) with some changes which I already had on a branch in my fork.
I was planning on adding them to v3. but you were faster :-)

if you don't like the additions, feel free to reject the PR

@lipkau lipkau assigned Dejulia489 and unassigned Dejulia489 Dec 29, 2018
@ghost ghost assigned lipkau Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants