Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: add skeleton for amico implementation #89
base: master
Are you sure you want to change the base?
FEAT: add skeleton for amico implementation #89
Changes from 3 commits
3b8210a
1a72f0d
f12ce31
3fa0f81
090b123
66f67e6
6a101b2
4ef1dbe
0278fa1
b398592
873fb4e
4a0d277
02ad74e
85994d9
55b76fe
9958209
626444f
d1b7100
4e1a38d
08d74e1
735b2a1
99168c0
fe3f35c
6d65658
51aa0ab
692bb15
3cee2c8
307958c
0e1f5bf
70d56cf
e7a506b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the predict function should be nonimplemented in this first MR since it addresses basic functionality of the fitted model.
Since in the first version we will not even have the lookup table, we will have to calculate the forward model matrix no matter if
acquisition_scheme=None
or something else.The code you wrote here appropriate for the follow-up MR with look-up table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's define if the LUT is part of the first MR or not ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed on no LUT for the moment.
Anyway, we need to think this properly. If we have the parameters fitted on a predefined set of orientations, how do we "register" this to the new acquisition scheme? Do we want to use a spherical harmonics representation and resample it accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, it would be tricky for different shells
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the function should look something like