Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request implements the CSD+ constraints proposed in https://doi.org/10.1016/j.neuroimage.2019.116405, discussed also in #91. The constraints can be used by setting
solver='csd_plus'
when fitting the model. I've included a simple example based on the existing MC-CSD example.It is recommended to install the MOSEK solver for speed, cf. https://docs.mosek.com/latest/install/installation.html for installation.
Some points:
sh_order
when using the constraints is currently 10, but this is not checked anywhere.