Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csd plus #116

Merged
merged 6 commits into from
Aug 24, 2022
Merged

Add csd plus #116

merged 6 commits into from
Aug 24, 2022

Conversation

tomdelahaije
Copy link
Contributor

This request implements the CSD+ constraints proposed in https://doi.org/10.1016/j.neuroimage.2019.116405, discussed also in #91. The constraints can be used by setting solver='csd_plus' when fitting the model. I've included a simple example based on the existing MC-CSD example.

It is recommended to install the MOSEK solver for speed, cf. https://docs.mosek.com/latest/install/installation.html for installation.

Some points:

  • The maximum value for sh_order when using the constraints is currently 10, but this is not checked anywhere.
  • The precomputed constraint matrices are stored as CSV files in dmipy/data/sos_constraints, but there is probably a more efficient way of storing/reading them.

@rutgerfick rutgerfick merged commit 459f77f into AthenaEPI:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants