Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable changing the provider for X509 certificate #2795

Conversation

gyakami
Copy link
Contributor

@gyakami gyakami commented Nov 12, 2024

Description

The provider used for issuing X509 certificates is currently fixed to BC. We have added a new property to allow changing this provider. Depending on the provider used, the RSAPrivateCrtKey interface might not be implemented. In such cases, casting will fail and an error will occur. Therefore, as a workaround, we have added the ATHENZ_CRYPTO_AUTHORITY_KEY_IDENTIFIER property to allow selecting whether to add the AUTHORITY KEY IDENTIFIER as an extension.

RSAPrivateCrtKey rsaCrtKey = (RSAPrivateCrtKey) privateKey;

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

@havetisyan havetisyan merged commit d04a6ff into AthenZ:master Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants