This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Bump to rulinalg 0.4 #167
Closed
Bump to rulinalg 0.4 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! If we merge we need to do a bump to 0.6 due to breaking changes (we reexport much of rulinalg). Because of this I'll try to get some of the other pending PRs in first. |
|
I'm in a tricky situation with this PR. We have a few other big PRs pending (as you can see, you authored many of them!). I would like to get this merged in first, but it puts pressure on other PRs to accommodate the breaking changes. What do you think of this? If you think we should get this in first then I am happy to make the changes to this PR myself and get it merged. |
|
Closing in favour of #174 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.