Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JA] review and modify week01, week02, week06, week07, week08, week09, week10, week11, week12, week13, week14, index.md and README-JA.md & some modifications & irrelevant files #731

Merged
merged 37 commits into from
Jul 29, 2022
Merged

[JA] review and modify week01, week02, week06, week07, week08, week09, week10, week11, week12, week13, week14, index.md and README-JA.md & some modifications & irrelevant files #731

merged 37 commits into from
Jul 29, 2022

Conversation

t46
Copy link
Contributor

@t46 t46 commented Dec 20, 2020 •
edited
Loading

I reviewed and modified week06. While rebasing on upstream master, I changed some files by mistake but the content of the file does not change. Because the contents of these files are the same as those in upstream master, I think these will not harm the project. So sorry for bothering you with such a mistake. If there is any inconvenience, let me know, I'll soon fix it up.

The main commits are following:

docs/ja/week01/
docs/ja/week02/
docs/ja/week06/
docs/ja/week07/
docs/ja/week08/
docs/ja/week09/
docs/ja/week10/
docs/ja/week11/
docs/ja/week12/
docs/ja/week13/
docs/ja/week14/
index.md
README-JA.md

Some modifications are done for the following files:

docs/ja/week03/03-1.md
docs/ja/week03/03-2.md
docs/ja/week04/04-1.md
docs/ja/week12/12-2.md

The others are irrelevant commits: changed by mistake but the content is the same.

Thanks

t46 and others added 22 commits December 20, 2020 15:13
@t46
add week07 drafts
acd208b
@t46
japanese translation week11
4cec649
@t46
add week07 & week11
22945bd
@t46
add week11 & week14
ba416e7
@t46
add week09
ddac9f0
@t46
add week03
70a7d12
@t46
review and modify week03
60a0f14
@JohnsonNguyen1820 @Atcold @t46
[VI] Translation of README.md, index.md, 01.md (Atcold#579)
5ab2192 
* index.md

* README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update index.md

* Create Lecture01.md

* Rename Lecture01.md to Lecture01.sbv

* Create Slide01.md

* Update and rename Slide01.md to 01.md

* Update index.md

* Create Lecture01.sbv

* Create 01.md

* Delete 01.md

* Delete Lecture01.sbv

* Update 01.md

* Update index.md

* Update README-VI.md

* Update and rename 01.md to ch01.md

* Update README-VI.md

* Update index.md

* Update index.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update and rename ch01.md to 01.md

* Update index.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update index.md

* Update index.md

* Update 01.md

* Update index.md

* Update index.md

* Create 01-1.md

* Update 01-1.md

* Update 01-1.md

* Update 01-1.md

* Update 01-1.md

* Update index.md

* Update index.md

* Update 01-1.md

* Update 01-1.md

* Update 01.md

* Update index.md

* Update 01-1.md

* Update 01-1.md

* Update 01-1.md

* Add Vietnamese flag

* All-caps title

* Rename docs/vi/week01/01.md to docs/vi/Tuần 01/01.md

* Update 01.md

* Rename docs/vi/week01/01-1.md to docs/vi/Tuần 01/01-1.md

* Rename docs/vi/week01/Lecture01.sbv to docs/vi/Tuần 01/Lecture01.sbv

* Update index.md

* Update index.md

* Update _config.yml

* Update 01-1.md

* Update 01-1.md

* Create 01-2.md

* Update 01-2.md

* Update 01-2.md

* Rename docs/vi/Tuần 01/01.md to docs/vi/Week01/01.md

* Rename docs/vi/Tuần 01/01-1.md to docs/vi/Week01/01-1.md

* Rename docs/vi/Tuần 01/01-2.md to docs/vi/Week01/01-2.md

* Rename docs/vi/Tuần 01/Lecture01.sbv to docs/vi/Week01/Lecture01.sbv

* Create 01-3.md

* Update 01-3.md

* Update 01-3.md

* Update 01-3.md

* Update 01-3.md

* Update 01-3.md

* Create practicum01.sbv

* Rename Lecture01.sbv to lecture01.sbv

* Delete lecture01.sbv

* Delete practicum01.sbv

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

Co-authored-by: Alfredo Canziani <[email protected]>
@JohnsonNguyen1820 @Atcold @t46
I had added Vietnam Translating Contents into README.md (Atcold#695)
0f4d518 
* Update README.md

* Update README.md

* Update README-AR.md

* Update README-ES.md

* Update README-FA.md

* Update README-FR.md

* Update README-IT.md

* Update README-JA.md

* Update README-JA.md

* Update README-KO.md

* Update README-RU.md

* Update README-TR.md

* Update README-ZH.md

* Update README-AR.md

* Update README-ES.md

* Update README-FA.md

* Update README-FR.md

* Update README-IT.md

Co-authored-by: Alfredo Canziani <[email protected]>
@ricardobarroslourenco @Atcold @t46
[pt] Begin translation to Portuguese (Atcold#542)
eff9c82 
* [pt_BR] Begin translation to Brazilian Portuguese.

* Accomodate changes

* Update README-PT.md

Co-authored-by: Alfredo Canziani <[email protected]>
@Atcold @t46
Add PT to all README-XX.md
683aa0f
@t46 @Atcold
[JA] translation of week01, week02, week03, week06, week08, week09, w…
bed932e 
…eek10, week11 , week12, week13 and week14 (Atcold#700)

* add week07 drafts

* Update 07-1.md

* Update 07-2.md

* Update 07-3.md

* Update 07.md

* Update _config.yml

* japanese translation week11

* japanese translation week11

* add week7

* add week07 & week11

* add week11 & week14

* add week12

* add week13

* add week06

* add week09

* add week10

* modify week14

* add week02

* add week01

* add week03

* add week08 (Jesmer Wong)

* review and modify week01

* add week02/02.md

* review and modify week02

* Update 03-2.md

* Update 03-3.md

* Update 06-1.md

* Update 06-2.md

* Update 06-3.md

* Update 06.md

* Update 07-2.md

* Update 07.md

* Update 09-1.md

* Update 09-3.md

* Update 09.md

* Update 10-1.md

* Update 10-2.md

* Update 10-3.md

* Update 10.md

* Update 11.md

* Update 12-1.md

* Update 12-2.md

* Update 12-3.md

* Update 12.md

* Update 13-1.md

* Update 13-2.md

* Update 13-3.md

* Update 13.md

* Update 14-1.md

* Update 14-2.md

* Update 14-3.md

* Update 14.md

* Update 11-3.md

* Update 11-2.md

* Update 11-1.md

* Update _config.yml

Co-authored-by: Alfredo Canziani <[email protected]>
@Atcold @t46
[JA] missing lang bug fix
08d3c21
@JohnsonNguyen1820 @t46
Update 01-1.md (Atcold#706)
6d4c8ea
@JohnsonNguyen1820 @t46
Update 01.md (Atcold#707)
4bb91bb
@JohnsonNguyen1820 @t46
Update 01-2.md (Atcold#709)
26c28ba
@JohnsonNguyen1820 @t46
Update 01-3.md (Atcold#710)
5f7a16f
@CodTan @Atcold @t46
[BN] Beginning translations to Bengali (Atcold#677)
566aa2c 
* Added README-BN.md and index.md for Bengali translation

* Added translation of 01.md

* Added Bengali section

* Added Bengali flag

* Added Bengali Flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

Co-authored-by: Alfredo Canziani <[email protected]>
@Atcold @t46
Fix BN index
4a47858
@t46
review and modify week06
01ce262
@t46
fix bug
2849aae
@t46
fix bug: corrected the edit of docs/pt/README-PT.md by mistake
1665ae8
@t46 t46 changed the title Ja translation/t46/add translation [JA] review and modify week06 & some modifications & irrelevant files Dec 20, 2020
@t46 t46 force-pushed the ja-translation/t46/add-translation branch from bce2414 to de44bca Compare December 21, 2020 02:59
@t46 t46 changed the title [JA] review and modify week06 & some modifications & irrelevant files [JA] review and modify week06 and week07 & some modifications & irrelevant files Dec 21, 2020
@t46 t46 changed the title [JA] review and modify week06 and week07 & some modifications & irrelevant files [JA] review and modify week06, week07 and 1eek08 & some modifications & irrelevant files Dec 23, 2020
@t46 t46 changed the title [JA] review and modify week06, week07 and 1eek08 & some modifications & irrelevant files [JA] review and modify week06, week07 and week08 & some modifications & irrelevant files Dec 23, 2020
@t46 t46 changed the title [JA] review and modify week06, week07 and week08 & some modifications & irrelevant files [JA] review and modify week06, week07, week08 and week09 & some modifications & irrelevant files Dec 24, 2020
@t46 t46 changed the title [JA] review and modify week06, week07, week08 and week09 & some modifications & irrelevant files [JA] review and modify week06, week07, week08, week09 and week10 & some modifications & irrelevant files Dec 25, 2020
@t46 t46 changed the title [JA] review and modify week06, week07, week08, week09 and week10 & some modifications & irrelevant files [JA] review and modify week06, week07, week08, week09, week10 and week11 & some modifications & irrelevant files Dec 26, 2020
@t46 t46 changed the title [JA] review and modify week06, week07, week08, week09, week10 and week11 & some modifications & irrelevant files [JA] review and modify week06, week07, week08, week09, week10, week11 and week12 & some modifications & irrelevant files Dec 27, 2020
@t46 t46 changed the title [JA] review and modify week06, week07, week08, week09, week10, week11 and week12 & some modifications & irrelevant files [JA] review and modify week06, week07, week08, week09, week10, week11, week12, week13 and week14 & some modifications & irrelevant files Dec 28, 2020
@t46 t46 changed the title [JA] review and modify week06, week07, week08, week09, week10, week11, week12, week13 and week14 & some modifications & irrelevant files [JA] review and modify week06, week07, week08, week09, week10, week11, week12, week13, week14, index.md and README-JA.md & some modifications & irrelevant files Dec 28, 2020
@t46 t46 changed the title [JA] review and modify week06, week07, week08, week09, week10, week11, week12, week13, week14, index.md and README-JA.md & some modifications & irrelevant files [JA] review and modify week01, week02, week06, week07, week08, week09, week10, week11, week12, week13, week14, index.md and README-JA.md & some modifications & irrelevant files Dec 28, 2020
@Atcold
Copy link
Owner

Atcold commented Jul 1, 2022

I just got notified about this (20 days ago).
I'm a little confused why it wasn't merged before.

@Atcold
Copy link
Owner

Atcold commented Jul 12, 2022

Hello @t46, can you give me some feedback?

@t46
Copy link
Contributor Author

t46 commented Jul 26, 2022

I think this PR was not merged just because this was not checked by any reviewers. But I think that is ready to be merged. Sorry for the messed up PR since I created this when I started GitHub.

Atcold
Atcold approved these changes Jul 29, 2022
View reviewed changes
Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@Atcold Atcold merged commit b69d480 into Atcold:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atcold Atcold Atcold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@t46 @Atcold @JohnsonNguyen1820 @ricardobarroslourenco @CodTan