Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZH] Fixing 13-3. #619

Merged
merged 2 commits into from
Sep 26, 2020
Merged

[ZH] Fixing 13-3. #619

merged 2 commits into from
Sep 26, 2020

Conversation

JonathanSum
Copy link
Contributor

#618

This Pull request should be closed. I tried to fix the issue for #618
by replacing the latex form the English file. But it looks like the GitHub thinks the latex is the same as the English version. I added a space to make GitHub thinks they are different. If after pulling this requestion and shows the issue is not fixed. It means the issue is not in the translated Chinese file.

@Atcold
Copy link
Owner

Atcold commented Sep 23, 2020

What am I supposed to do with this PR?

@JonathanSum
Copy link
Contributor Author

I guess the reason why the latex is broke is the front type:

It is either the first one is from the English version or the Chinese version, but you can see they are different.

$\lbrace\boldsymbol{x}{i}\rbrace^{t}{i=1}$
$\lbrace\boldsymbol{x}
{i}\rbrace^{t}{i=1}$

$\boldsymbol{h}$
$\boldsymbol{h}$

$\boldsymbol{X}\boldsymbol{a}$
$\boldsymbol{X}\boldsymbol{a}$

$\boldsymbol{a}$
$\boldsymbol{a}$

$\boldsymbol{x}{i}$
$\boldsymbol{x}{i}$

If after you merged it and the latex issue remains, I don't know what to do.

@JonathanSum
Copy link
Contributor Author

JonathanSum commented Sep 24, 2020

I will follow this pull request as a guideline to fix it.
#576

@JonathanSum
Copy link
Contributor Author

JonathanSum commented Sep 24, 2020

I have added little changes in the Chinese translation to improve its translation, but the Latex is still the same as the English one.
I will test it on Sunday or Monday.

@JonathanSum
Copy link
Contributor Author

Updated: I have improved a little bit on Chinese translation.
But the latex is not fixed yet. I will pick another day to find a way to fix them.

Please feel free to pull this one only for a translation update.

Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I can try to help fixing the LaTeX next week.

@Atcold Atcold merged commit 0d06b97 into Atcold:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants