-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Dutch translations to Prismatik #3
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,776 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<!DOCTYPE TS> | |||
<TS version="2.0" language="ru_RU"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be: <TS version="2.0" language="nl_NL">
I made a small boo boo.
lrelease error: Parse error at D:/System/Users/Tim/Projects/light-nl/Software/src/../res/translations/nl_NL.ts:97:31: Entity 'euml' not declared. Thanks for contributing! |
btw Qt5.1.1, Win7 |
a well, then |
<location filename="../../src/SettingsWindow.ui" line="1454"/> | ||
<location filename="../../src/SettingsWindow.ui" line="1654"/> | ||
<source>Serial port:</source> | ||
<translation>Seriële poort:</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ë
should be written as ë
because it is an unknown entity within the Qt compiler
I apologize for the avalanche of comments, but in my experience a bad translation is more annoying than no translation at all. Your translation is great for the most part, but I think there are some places where it can be improved. If you don't feel like making all of those changes yourself, the Lightpack folks can just merge this PR and I'll send another one with my proposed changes. |
Fix compilation with Mac SDK below 10.9 and clear some warnings.
I provided the res/languages/nl_NL.ts file