Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR piggybacks on #6. cc/ @JoshyPHP
I noticed some random emojis weren't being converted, even with #6. Things like π, β€οΈβπ₯, and ππ»ββοΈ.
Now I'll be honest, I have no idea how Unicode works.
But I know that @JoshyPHP does, so I tried adapting this logic from the s9e/TextFormatter Emoji plugin, to normalize the codepoints so they work with Twemoji:
And lo and behold, it works! I added some tests with some of the more complex emojis that were failing before, which work great now.