Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): fix clippy config, add --no-deps arg #978

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

Ryex
Copy link
Contributor

@Ryex Ryex commented May 20, 2024

📑 Description

Prevent rustaceanvim from enabling clippy on it's own. This results in a bad config atm. and would clash with any user provided config / this packs config if it worked.

Add the --no-deps clippy arg to not lint dependencies by default

ℹ Additional Information

this would fix rustacenvim 's bad clippy config but we should still disable it because it on it's side because will overwrite ours when
load_rust_analyzer_settings is called
mrcjkb/rustaceanvim#403

prevent rustaceanvim from enableing it on it's own
Copy link

github-actions bot commented May 20, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft merged commit b092e34 into AstroNvim:main May 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants