Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pack): update typescript-all-in-one disable typescript-tools to denols #876

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

JamsMendez
Copy link
Contributor

📑 Description

In the pack typescript-all-in-one disable typescript-tools and tsserver to denols. Apparently tsserver is disabled but typescript-tools keeps tsserver errors active again.

ℹ Additional Information

Screenshot 2024-04-11 111539

Copy link

github-actions bot commented Apr 11, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member

Uzaaft commented Apr 11, 2024

@JamsMendez Can you explain better what this PR does? Your original message didn't make much sense for me.

@JamsMendez
Copy link
Contributor Author

@JamsMendez Can you explain better what this PR does? Your original message didn't make much sense for me.

Sorry @Uzaaft, the context is the following:
add in community.lua
{ import = "astrocommunity.pack.typescript-all-in-one" }
And in the astrolsp.lua configure tsserver so that the root_dir for package.json and tsconfig.json.
But when I open a Deno project the tsserver shows the errors of "cannot find name Deno", "Cannot find module...", etc.
Although the pack disables lsp tsserver, this is caused by lsp typescript-tools. As shown in the previous image.
The PR in summary disables typescript-tools so that these error messages are not displayed and Deno is the main lsp.

@Uzaaft
Copy link
Member

Uzaaft commented Apr 15, 2024

I'm going to wait on merging this one until I find time to test it properly.

@aslak01
Copy link
Contributor

aslak01 commented Apr 24, 2024

Can confirm this is an issue, I used this solution to solve: pmizio/typescript-tools.nvim#248

@mehalter mehalter changed the title feat(pack): update typescript-all-in-one disable typescript-tools to denols fix(pack): update typescript-all-in-one disable typescript-tools to denols Apr 25, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bit of cleanup and made the modifications user facing so they can choose to disable them! I'll go ahead and merge this and if something is broken we can have follow up PRs. Also snuck in some fixes across other stuff which isn't a huge deal haha not worth another PR

@mehalter mehalter merged commit 4bccd65 into AstroNvim:main Apr 25, 2024
12 checks passed
@mehalter
Copy link
Member

Thanks for starting this @JamsMendez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants