-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pack): update typescript-all-in-one disable typescript-tools to denols #876
Conversation
…ipt-tools to denols
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
@JamsMendez Can you explain better what this PR does? Your original message didn't make much sense for me. |
Sorry @Uzaaft, the context is the following: |
I'm going to wait on merging this one until I find time to test it properly. |
Can confirm this is an issue, I used this solution to solve: pmizio/typescript-tools.nvim#248 |
…` implementation
ea5fab8
to
582696a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a bit of cleanup and made the modifications user facing so they can choose to disable them! I'll go ahead and merge this and if something is broken we can have follow up PRs. Also snuck in some fixes across other stuff which isn't a huge deal haha not worth another PR
Thanks for starting this @JamsMendez ! |
📑 Description
In the pack typescript-all-in-one disable typescript-tools and tsserver to denols. Apparently tsserver is disabled but typescript-tools keeps tsserver errors active again.
ℹ Additional Information