Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add fish pack #817

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Conversation

manuuurino
Copy link
Contributor

No description provided.

Copy link

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member

Uzaaft commented Mar 29, 2024

@manuuurino I'd appreciate it if you take a look at other similar packs before opening a PR.
Also, please add WhoIsSethDaniel/mason-tool-installer.nvim into the pack as well with optional support

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add WhoIsSethDaniel/mason-tool-installer.nvim into the pack

@manuuurino
Copy link
Contributor Author

forgot to mention there is no mason package for fish and fish_indent, also tried your commit and it tells me this aswell

@Uzaaft
Copy link
Member

Uzaaft commented Mar 30, 2024

forgot to mention there is no mason package for fish and fish_indent, also tried your commit and it tells me this aswell

You should mention the dependency on fish in the readme, even if its a no-brainer that it's required

@Uzaaft Uzaaft merged commit b1584b9 into AstroNvim:v4 Mar 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants