Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swift): fix LSP handler error #655

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix(swift): fix LSP handler error #655

merged 1 commit into from
Nov 30, 2023

Conversation

andreacfromtheapp
Copy link
Contributor

@andreacfromtheapp andreacfromtheapp commented Nov 26, 2023

📑 Description

fixing an issue where:

  • enabling { import = "astrocommunity.pack.swift" },

  • enabling lsp = { servers = { "sourcekit"} } (not installed with mason)

  • would trigger this error:

[lspconfig] Cannot access configuration for sourcekit-lsp. Ensure this server is listed in "server_configurations.md" or added to a custom server.

Copy link

github-actions bot commented Nov 26, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title fix(pack-swift): fix LSP handler error fix(swift): fix LSP handler error Nov 26, 2023
@andreacfromtheapp
Copy link
Contributor Author

After some considerations and comments from @Uzaaft I gave it another try. here's what works:

1 - pack/swift/init.lua with only xbase (sourcekit line restored with changes, null-ls removed) + treesitter + dap
2 - no lsp config in user/init.lua needed
3 - swiftformat + swiftlint added to user/null-ls.lua (adding them to the pack was opinionated)

notes: if null-ls is present in pack/swift only it won't use them for some reason, two birds with a stone: unopinionated + user defined == this way the change is minimal, unopinionated and 100% working 🙂

I hope this helps. If I made mistakes I apologize. If this is bad somehow, feel free to refuse it. I won't take it persoally :)

@Uzaaft Uzaaft merged commit 617bc28 into AstroNvim:main Nov 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants